On (05/27/16 13:31), Minchan Kim wrote:
[..]
> >  int zcomp_compress(struct zcomp_strm *zstrm,
> > -           const unsigned char *src, unsigned int *dst_len)
> > +           const u8 *src, unsigned int *dst_len)
> 
> Nitpick:
> 
> The zcomp doesn't need to depend on implementation(i.e., crypto) so
> zcomp_compress should pass void * for src and dst.
> 
> I'm not strong aginst changing u8 but your description makes me
> think about that. 

no strong opinion on this either.

        -ss

Reply via email to