On Mon, 2007-01-29 at 16:08 +1100, Neil Brown wrote: > On Monday August 21, [EMAIL PROTECTED] wrote: > > > > Could we instead replace it with a dprintk() that returns the value of > > "res"? That will keep it useful for debugging purposes. > > (only 5 months later...) > > Sure, how about this? > > Thanks, > NeilBrown
ACKed. Thanks Neil! Trond > > Remove warning: VFS is out of sync with lock manager. > > But keep it as a dprintk > > The message can be generated in a quite normal situation: > If a 'lock' request is interrupted, then the lock client needs to > record that the server has the lock, incase it does. > When we come the unlock, the server might say it doesn't, even > though we think it does (or might) and this generates the message. > > Signed-off-by: Neil Brown <[EMAIL PROTECTED]> > > ### Diffstat output > ./fs/nfs/file.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff .prev/fs/nfs/file.c ./fs/nfs/file.c > --- .prev/fs/nfs/file.c 2007-01-29 16:04:09.000000000 +1100 > +++ ./fs/nfs/file.c 2007-01-29 16:04:45.000000000 +1100 > @@ -434,8 +434,9 @@ static int do_vfs_lock(struct file *file > BUG(); > } > if (res < 0) > - printk(KERN_WARNING "%s: VFS is out of sync with lock > manager!\n", > - __FUNCTION__); > + dprintk(KERN_WARNING "%s: VFS is out of sync with lock manager" > + " - error %d!\n", > + __FUNCTION__, res); > return res; > } > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
