On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote: > This is a patch to the s626.c file that fixes up a Block comments > issues found by the checkpatch.pl tool. > > i.e. Block comments use a trailing */ on a separate line > > Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankark...@gmail.com>
We can see in the diff this is making changes in s626.c :) no need to mention that in the commit message. Not sure moving the opening and closing of comments (/* and */) to a new line makes things more readable. checkpatch is a great tool but it gives suggestions, not hard rules. Just a comment since I've seen multiple people follow checkpatch blindly, and it is best to use your discretion. Maintainer of this code will probably have a preference. Thank you for your patches Ravishankar. Luis
