<mario_limoncie...@dell.com> writes:
>> > +static u8 amac_ascii_to_hex(int c)
>> > +{
>> > + if (c <= 0x39)
>> > + return (u8)(c - 0x30);
>> > + else if (c <= 0x46)
>> > + return (u8)(c - 0x37);
>> > + return (u8)(c - 0x57);
>> > +}
>>
>
> Sorry forgot to address this.
>
>> We really don't have such a function somewhere in the kernel already?
>
> There is a function in acpi/acpica/uthex.c that does this, but it doesn't
> seem to be used by anything outside of acpica so far. Would it be OK style
> wise to
> #include " ../../acpi/acpica/acutils.h" from r8152.c?
Makes me wonder where you looked.... You have hex_to_bin() and
hex2bin() in include/linux/kernel.h
You could look at usbnet_get_ethernet_addr() for an example of how to do
this properly. It's pretty close to this driver in the tree, and should
be a natural starting point before reinventing the wheel...
Bjørn
