2016-06-02 18:07 GMT+02:00 Maxime Coquelin <mcoquelin.st...@gmail.com>: > 2016-06-02 16:26 GMT+02:00 M'boumba Cedric Madianga > <cedric.madia...@gmail.com>: >> Signed-off-by: Patrice Chotard <patrice.chot...@st.com> >> Signed-off-by: M'boumba Cedric Madianga <cedric.madia...@gmail.com> >> --- >> arch/arm/boot/dts/stm32f429.dtsi | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/arch/arm/boot/dts/stm32f429.dtsi >> b/arch/arm/boot/dts/stm32f429.dtsi >> index 434d4b9..d5857eb 100644 >> --- a/arch/arm/boot/dts/stm32f429.dtsi >> +++ b/arch/arm/boot/dts/stm32f429.dtsi >> @@ -323,6 +323,18 @@ >> slew-rate = <2>; >> }; >> }; >> + >> + i2c1_sda_pin: i2c1_sda@0 { >> + pins { >> + pinmux = >> <STM32F429_PB9_FUNC_I2C1_SDA>; >> + drive-open-drain; >> + }; >> + }; >> + i2c1_scl_pin: i2c1_scl@0 { >> + pins { >> + pinmux = >> <STM32F429_PB6_FUNC_I2C1_SCL>; >> + }; >> + }; >> }; > Shouldn't be preferrable to group the two functions in a single one, I agree. It is better. > > usart1_pins_a: usart1@0 { > pins1 { > pinmux = <STM32F429_PA9_FUNC_USART1_TX>; > bias-disable; > drive-push-pull; > slew-rate = <0>; > }; > pins2 { > pinmux = <STM32F429_PA10_FUNC_USART1_RX>; > bias-disable; > }; > }; > > Also, I would prefer the phandle to be suffixed with the port number, > as multiple muxing options are available, for example "i2c1_pins_b". Ok understood. I will fix that in the V3. Thanks > > Thanks, > Maxime