On 01/06/2016 at 11:59:54 +0530, venkat.prashanth2...@gmail.com wrote : > From: VENKAT PRASHANTH B U <venkat.prashanth2...@gmail.com> > > This is a patch to add support for > maxim rtc max6916 > > Signed-off-by: Venkat Prashanth B U <venkat.prashanth2...@gmail.com> > --- > changelog v4: > - fixed the line wrapping to around 72 characters > - Aligned the values with tabs > - inserted the correct coding style in the conditional statements > - removed the empty lines towards the end of the code > - fixed the checkpatch issues > - code clean up on max6916_read_reg() > > changelog v3: > - saperated the logical code sections with an empty line > - used indentations after if statements. > - fixed the out of tree makefile > - placed the test condition at the begining of the function > > change log v2: > - deleted the port i/o's > - clock burst value is modified from 0x00 to 0x3F > - The time in linux is in binary format so get_rtc()replaced with bcd2bin() > - enforced the year range instead of accepting any value > --- > --- > drivers/rtc/Kconfig | 12 ++++ > drivers/rtc/Makefile | 1 + > drivers/rtc/rtc-max6916.c | 167 > ++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 180 insertions(+) >
I've applied it but you probably edited the diff by hand so I had to edit it a bit more to get it to apply correctly. Also, I fixed the remaining checkpatch issues. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
