> -----Original Message----- > From: Greg KH [mailto:[email protected]] > Sent: Monday, June 6, 2016 9:40 AM > To: Limonciello, Mario <[email protected]> > Cc: [email protected]; LKML <[email protected]>; Netdev > <[email protected]>; Linux USB <[email protected]>; > [email protected]; [email protected] > Subject: Re: [PATCH v3] r8152: Add support for setting pass through MAC > address on RTL8153-AD > > On Mon, Jun 06, 2016 at 09:15:20AM -0500, Mario Limonciello wrote: > > Since this is a Realtek feature, I feel this shouldn't be moved into a > > platform > > MAC address lookup. The code should only be run when the correct > Realtek device > > is plugged in. > > > > Changes from v2: > > * Only apply to RTL8153-AD w/ eFuse pass through mac address pass thru > > bit set. > > * Drop matching DMI information on Dell. Although this is implemented > on > > Dell, this is a Realtek feature that may may be implemented on other > > OEMs as well. > > * Test that pass through MAC address is valid, fall back to HW address if > > invalid. > > * Don't track status of which device has MAC pass through activated. > > - Expected experience is that if two docks (RTL8153-AD's w/ mac pass thru > > bit set) were plugged in both should have MAC pass through activated. > > cover letters for single-patch submissions is overkill and confusing, > please don't.
I was trying to convey differences between versions of this patch, I'll avoid that in the future and let the audience find them themselves.
