Robert Hancock wrote:
Applies to 2.6.20-rc6.
---
libata's SCSI translation for the SCSI START STOP UNIT command with the
START bit clear (i.e. stopping the drive) appears to be incorrect. It
sends an ATA STANDBY command with the time period set to 0, which the
code comment says means "now", but the ATA standard says this means
disable the standby timer, which effectively does nothing. Change this
to issue a STANDBY IMMEDIATE command which will actually spin the drive
down. The SAT (SCSI/ATA Translation) standard revision 9 concurs with
this choice.
Signed-off-by: Robert Hancock <[EMAIL PROTECTED]>
FWIW, I am having to apply Andrew Morton's version of your patches,
because your patch form isn't quite right. Review
Documentation/SubmittingPatches and http://linux.yyz.us/patch-format.html
Most notably:
* Your patch description follows the "---" terminator, which is
precisely the opposite of what should happen. In the correct form, any
comments such as "Applies to 2.6.20-rc6" should follow the "---"
terminator, which in turn follows the patch description and signoff.
* Include the patch inline rather than as an attachment. Even a
text/plain attachment is very difficult to review and quote in popular
email programs.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
