Hi Vinod, Thanks for reviewing.
On Mon, 06 Jun 2016, Vinod Koul wrote: > On Wed, May 25, 2016 at 05:06:39PM +0100, Peter Griffin wrote: > > > +/* > > + * request control bits > > + */ > > +#define REQ_CTRL_NUM_OPS_MASK GENMASK(31, 24) > > +#define REQ_CTRL_NUM_OPS(n) (REQ_CTRL_NUM_OPS_MASK & ((n) > > << 24)) > > +#define REQ_CTRL_INITIATOR_MASK BIT(22) > > +#define REQ_CTRL_INIT0 (0x0 << 22) > > +#define REQ_CTRL_INIT1 (0x1 << 22) > > pls keep spaces or tabs, not both :( Will fix in v5. > > > +#define REQ_CTRL_INC_ADDR_ON BIT(21) > > +#define REQ_CTRL_DATA_SWAP_ON BIT(17) > > +#define REQ_CTRL_WNR BIT(14) > > +#define REQ_CTRL_OPCODE_MASK GENMASK(7, 4) > > +#define REQ_CTRL_OPCODE_LD_ST1 (0x0 << 4) > > +#define REQ_CTRL_OPCODE_LD_ST2 (0x1 << 4) > > +#define REQ_CTRL_OPCODE_LD_ST4 (0x2 << 4) > > +#define REQ_CTRL_OPCODE_LD_ST8 (0x3 << 4) > > +#define REQ_CTRL_OPCODE_LD_ST16 (0x4 << 4) > > +#define REQ_CTRL_OPCODE_LD_ST32 (0x5 << 4) > > +#define REQ_CTRL_OPCODE_LD_ST64 (0x6 << 4) > > +#define REQ_CTRL_HOLDOFF_MASK GENMASK(2, 0) > > +#define REQ_CTRL_HOLDOFF(n) ((n) & REQ_CTRL_HOLDOFF_MASK) > > Everything here is FDMA_ so why not these as well > Everything apart from this and NODE_CTRL_*. I will add FDMA_ prefix to all in v5. regards, Peter.
