On Thu, 12 May 2016, Rhyland Klein wrote: > When configuring FPS during probe, assuming a DT node is present for > FPS, the code can run into a problem with the switch statements in > max77620_config_fps() and max77620_get_fps_period_reg_value(). Namely, > in the case of chip->chip_id == MAX77620, it will set > fps_[mix|max]_period but then fall through to the default switch case > and return -EINVAL. Returning this from max77620_config_fps() will > cause probe to fail. > > Signed-off-by: Rhyland Klein <[email protected]> > --- > drivers/mfd/max77620.c | 2 ++ > 1 file changed, 2 insertions(+)
Applied to -fixes with Thierry and Laxman's Acks. > diff --git a/drivers/mfd/max77620.c b/drivers/mfd/max77620.c > index 199d261990be..f32fbb8e8129 100644 > --- a/drivers/mfd/max77620.c > +++ b/drivers/mfd/max77620.c > @@ -203,6 +203,7 @@ static int max77620_get_fps_period_reg_value(struct > max77620_chip *chip, > break; > case MAX77620: > fps_min_period = MAX77620_FPS_PERIOD_MIN_US; > + break; > default: > return -EINVAL; > } > @@ -236,6 +237,7 @@ static int max77620_config_fps(struct max77620_chip *chip, > break; > case MAX77620: > fps_max_period = MAX77620_FPS_PERIOD_MAX_US; > + break; > default: > return -EINVAL; > } -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
