On Tue, 07 Jun 2016, Peter Griffin wrote:
> Hi Lee,
>
> On Fri, 22 Apr 2016, Lee Jones wrote:
>
> > Here we're requesting the PWM Capture IRQ and supplying the
> > handler which will be called in the event of an IRQ fire to
> > handle it.
> >
> > Signed-off-by: Lee Jones <lee.jo...@linaro.org>
> > ---
> > drivers/pwm/pwm-sti.c | 92
> > ++++++++++++++++++++++++++++++++++++++++++++++++++-
> > 1 file changed, 91 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/pwm/pwm-sti.c b/drivers/pwm/pwm-sti.c
> > index 9d597bb..2230afb 100644
> > --- a/drivers/pwm/pwm-sti.c
> > +++ b/drivers/pwm/pwm-sti.c
[...]
Please cut any large chunks of unnecessary cruft when reviewing.
> > @@ -367,7 +444,7 @@ static int sti_pwm_probe(struct platform_device *pdev)
> > struct sti_pwm_chip *pc;
> > struct resource *res;
> > unsigned int devnum;
> > - int ret;
> > + int irq, ret;
> >
> > pc = devm_kzalloc(dev, sizeof(*pc), GFP_KERNEL);
> > if (!pc)
> > @@ -388,6 +465,19 @@ static int sti_pwm_probe(struct platform_device *pdev)
> > if (IS_ERR(pc->regmap))
> > return PTR_ERR(pc->regmap);
> >
> > + irq = platform_get_irq(pdev, 0);
> > + if (irq < 0) {
> > + dev_err(&pdev->dev, "Failed to obtain IRQ\n");
> > + return irq;
> > + }
> > +
> > + ret = devm_request_irq(&pdev->dev, irq, sti_pwm_interrupt,
> > + 0, pdev->name, pc);
> > + if (ret < 0) {
> > + dev_err(&pdev->dev, "Failed to request IRQ\n");
> > + return ret;
> > + }
> > +
> > /*
> > * Setup PWM data with default values: some values could be replaced
> > * with specific ones provided from Device Tree.
>
> pwm-st.txt dt binding document and pwm example needs updating to document this
> irq.
Yes, it does. I will update the documentation and place it into this
patch-set on next submission.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
