On Fri, Jun 03, 2016 at 12:56:21PM +0800, Garlic Tseng wrote:

> +     if (val < 0 || val > MT2701_I2S_NUM) {
> +             dev_err(afe->dev, "%s, num not available, num %d, val %d\n",
> +                     __func__, num, val);
> +             return -1;

Real error codes please.

> +static const struct snd_kcontrol_new mt2701_afe_multi_ch_out_asrc3[] = {
> +     SOC_DAPM_SINGLE_AUTODISABLE("Multi ch asrc out3", PWR2_TOP_CON, 7, 1,
> +                                 1),
> +};

On/off controls should end in Switch.

Attachment: signature.asc
Description: PGP signature

Reply via email to