* Peter Zijlstra <[email protected]> wrote:
> On Tue, Jun 07, 2016 at 04:31:01PM -0700, H. Peter Anvin wrote:
> > From: "H. Peter Anvin" <[email protected]>
> >
> > The gcc people have confirmed that using "bool" when combined with
> > inline assembly always is treated as a byte-sized operand that can be
> > assumed to be 0 or 1, which is exactly what the SET instruction
> > emits. Change the output types and intermediate variables of as many
> > operations as practical to "bool".
> >
> > Signed-off-by: H. Peter Anvin <[email protected]>
> > ---
> > arch/x86/boot/bitops.h | 8 +++++---
> > arch/x86/boot/boot.h | 8 ++++----
> > arch/x86/boot/string.c | 2 +-
> > arch/x86/include/asm/apm.h | 6 +++---
> > arch/x86/include/asm/archrandom.h | 16 ++++++++--------
> > arch/x86/include/asm/atomic.h | 8 ++++----
> > arch/x86/include/asm/atomic64_64.h | 10 +++++-----
> > arch/x86/include/asm/bitops.h | 28 ++++++++++++++--------------
> > arch/x86/include/asm/local.h | 8 ++++----
> > arch/x86/include/asm/percpu.h | 8 ++++----
> > arch/x86/include/asm/rmwcc.h | 4 ++--
> > arch/x86/include/asm/rwsem.h | 17 +++++++++--------
> > include/linux/random.h | 12 ++++++------
> > 13 files changed, 69 insertions(+), 66 deletions(-)
>
> So the only concern I have with this is that the x86 function signatures
> are now different from the other architectures.
>
> Not sure how much if anything that matters..
It does matter:
In file included from arch/x86/kernel/cpu/common.c:21:0:
./arch/x86/include/asm/archrandom.h:95:20: error: redefinition of
‘arch_get_random_long’
static inline bool arch_get_random_long(unsigned long *v)
In file included from ./arch/x86/include/asm/stackprotector.h:43:0,
include/linux/random.h:98:20: note: previous definition of
‘arch_get_random_long’ was here
Thanks,
Ingo
