On Wed, 01 Jun 2016, John Stultz wrote:
> While trying to get the powerkey to function, I found
> when pressing the key, I would get infinitely repeating
> interrupts.
>
> After digging around a bit, it seems we didn't set the
> ack_base value for the regmap irqchip logic, so nothing
> was acking the interrupt.
>
> This patch adds the ack_base, which seems to make things
> work.
>
> Cc: Dmitry Torokhov <dmitry.torok...@gmail.com>
> Cc: Rob Herring <robh...@kernel.org>
> Cc: Pawel Moll <pawel.m...@arm.com>
> Cc: Mark Rutland <mark.rutl...@arm.com>
> Cc: Ian Campbell <ijc+devicet...@hellion.org.uk>
> Cc: Kumar Gala <ga...@codeaurora.org>
> Cc: Lee Jones <lee.jo...@linaro.org>
> Cc: Jorge Ramirez-Ortiz <jorge.ramirez-or...@linaro.org>
> Cc: Wei Xu <xuw...@hisilicon.com>
> Cc: Guodong Xu <guodong...@linaro.org>
> Signed-off-by: John Stultz <john.stu...@linaro.org>
> ---
> drivers/mfd/hi655x-pmic.c | 1 +
> 1 file changed, 1 insertion(+)
Seems reasonable.
Acked-by: Lee Jones <lee.jo...@linaro.org>
> diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c
> index 3511035..4a3fdbc 100644
> --- a/drivers/mfd/hi655x-pmic.c
> +++ b/drivers/mfd/hi655x-pmic.c
> @@ -50,6 +50,7 @@ static const struct regmap_irq_chip hi655x_irq_chip = {
> .num_regs = 1,
> .num_irqs = ARRAY_SIZE(hi655x_irqs),
> .status_base = HI655X_IRQ_STAT_BASE,
> + .ack_base = HI655X_IRQ_STAT_BASE,
> .mask_base = HI655X_IRQ_MASK_BASE,
> };
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
