On Wed, 01 Jun 2016, John Stultz wrote: > While trying to get the powerkey to function, I found > when pressing the key, I would get infinitely repeating > interrupts. > > After digging around a bit, it seems we didn't set the > ack_base value for the regmap irqchip logic, so nothing > was acking the interrupt. > > This patch adds the ack_base, which seems to make things > work. > > Cc: Dmitry Torokhov <[email protected]> > Cc: Rob Herring <[email protected]> > Cc: Pawel Moll <[email protected]> > Cc: Mark Rutland <[email protected]> > Cc: Ian Campbell <[email protected]> > Cc: Kumar Gala <[email protected]> > Cc: Lee Jones <[email protected]> > Cc: Jorge Ramirez-Ortiz <[email protected]> > Cc: Wei Xu <[email protected]> > Cc: Guodong Xu <[email protected]> > Signed-off-by: John Stultz <[email protected]> > --- > drivers/mfd/hi655x-pmic.c | 1 + > 1 file changed, 1 insertion(+)
Seems reasonable. Acked-by: Lee Jones <[email protected]> > diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c > index 3511035..4a3fdbc 100644 > --- a/drivers/mfd/hi655x-pmic.c > +++ b/drivers/mfd/hi655x-pmic.c > @@ -50,6 +50,7 @@ static const struct regmap_irq_chip hi655x_irq_chip = { > .num_regs = 1, > .num_irqs = ARRAY_SIZE(hi655x_irqs), > .status_base = HI655X_IRQ_STAT_BASE, > + .ack_base = HI655X_IRQ_STAT_BASE, > .mask_base = HI655X_IRQ_MASK_BASE, > }; > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
