> From: Javier Martinez Canillas [mailto:jav...@osg.samsung.com] > Sent: Friday, May 27, 2016 7:48 PM > To: linux-kernel@vger.kernel.org > Cc: Xinming Hu; Javier Martinez Canillas; Amitkumar Karwar; Kalle Valo; > net...@vger.kernel.org; linux-wirel...@vger.kernel.org; Nishant > Sarmukadam > Subject: [PATCH 0/8] mwifiex: Fix some error handling issues in > mwifiex_sdio_probe() function > > Hello, > > While booting a system with a mwifiex WiFi card, I noticed the following > missleading error message: > > [ 12.480042] mwifiex_sdio mmc2:0001:1: sdio platform data not available > > This error only applies to platforms that define a child node for the > SDIO device, but it's currently shown even in platforms that don't have > a child node defined. > > So this series fixes this issue and others I found in the .probe > function (mostly related to error handling and the error path) while > looking at it. > > Best regards, > Javier > > > Javier Martinez Canillas (8): > mwifiex: only call mwifiex_sdio_probe_of() if dev has an OF node > mwifiex: propagate sdio_enable_func() errno code in > mwifiex_sdio_probe() > mwifiex: propagate mwifiex_add_card() errno code in > mwifiex_sdio_probe() > mwifiex: consolidate mwifiex_sdio_probe() error paths > mwifiex: use dev_err() instead of pr_err() in mwifiex_sdio_probe() > mwifiex: check if mwifiex_sdio_probe_of() fails and return error > mwifiex: don't print an error if an optional DT property is missing > mwifiex: use better message and error code when OF node doesn't match > > drivers/net/wireless/marvell/mwifiex/sdio.c | 46 ++++++++++++++++++---- > ------- > 1 file changed, 28 insertions(+), 18 deletions(-) >
Thanks for fixing the error handling code. These patches look fine to me. Acked-by: Amitkumar Karwar <akar...@marvell.com> Regards, Amitkumar
