Hi, Arnaldo :)
Thank you for your review.
On 06/09/2016 10:29 PM, Arnaldo Carvalho de Melo wrote:
Em Wed, Jun 08, 2016 at 09:36:50PM +0900, Taeung Song escreveu:
Lately util/config.h has been added
but util/cache.h has declarations of functions
and extern variable for config features.
To manage codes about configuration at one spot, move them
to util/config.h and util/cache.h include util/config.h
Cc: Alexander Shishkin <alexander.shish...@linux.intel.com>
Cc: Jiri Olsa <jo...@redhat.com>
Cc: Masami Hiramatsu <mhira...@kernel.org>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Wang Nan <wangn...@huawei.com>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/util/cache.h | 13 +------------
tools/perf/util/config.h | 12 ++++++++++++
2 files changed, 13 insertions(+), 12 deletions(-)
diff --git a/tools/perf/util/cache.h b/tools/perf/util/cache.h
index 0d814bb..cd8cd4d 100644
--- a/tools/perf/util/cache.h
+++ b/tools/perf/util/cache.h
@@ -7,6 +7,7 @@
#include <subcmd/pager.h>
#include "../perf.h"
#include "../ui/ui.h"
+#include "config.h"
Why have you added that? Are those config functions used in cache.h?
Yes, it does. Many source files include cache.h
e.g. builtin-annoate.c, util/color.c, builtin-report.c and etc.
And They can use perf_config() function including this header file.
So, If I totally eliminate not only declarations about config
but also #include "util/config.h" at util/cache.h,
we should add '#include "util/config.h"' to each source file that
need perf_config() overall.
But IMHO, if cache.h include config.h,
we don't need to find source files that use perf_config().
Thanks,
Taeung
