Move the block testing result < 0 to avoid the test immediately after setting result = 0
Signed-off-by: Quentin Armitage <quen...@armitage.org.uk> --- net/netfilter/ipvs/ip_vs_sync.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/net/netfilter/ipvs/ip_vs_sync.c b/net/netfilter/ipvs/ip_vs_sync.c index d52cc25..0ca937a 100644 --- a/net/netfilter/ipvs/ip_vs_sync.c +++ b/net/netfilter/ipvs/ip_vs_sync.c @@ -1495,14 +1495,14 @@ static struct socket *make_send_sock(struct netns_ipvs *ipvs, int id, struct net if (result > 0) set_sock_size(sock->sk, 1, result); - if (AF_INET == ipvs->mcfg.mcast_af) + if (AF_INET == ipvs->mcfg.mcast_af) { result = bind_mcastif_addr(sock, dev); - else + if (result < 0) { + pr_err("Error binding address of the mcast interface\n"); + goto error; + } + } else result = 0; - if (result < 0) { - pr_err("Error binding address of the mcast interface\n"); - goto error; - } get_mcast_sockaddr(&mcast_addr, &salen, &ipvs->mcfg, id); result = sock->ops->connect(sock, (struct sockaddr *) &mcast_addr, -- 1.7.7.6