On 15/06/16 04:17 PM, Allen Hubbe wrote: > This test should fail on Intel RP/TB topology (two cpu sharing one ntb). The > link state is the link state of the secondary side pcie bus connected to the > secondary side cpu. The link must be up in order for the secondary side cpu > to discover the ntb device, so the driver does not allow the link to be > disabled in such topology.
Ok, I wasn't aware of this. But looking closer I think I have a better solution: ntb_link_disable should return -EINVAL if the hardware can't support bringing the link down. If I add the error check to my tool_link_write (which I neglected to do) then writing an "N" to $LOC/link will fail and the test could be skipped. I'll make a v4 spin. Logan > A simple thing to do here might be: > > write_file "N" "$LOC/link" > sleep 1 > read_file "$REM/link" > > You already have my Ack. This minor issue can be fixed later if anyone > cares. I don't think it is a big deal, just worth pointing out that the > script will hang here instead of report a failure. If it is worth fixing > later, at that point we might also want to change this script to continue > with other tests instead of exit on the first failure. >
