On 06/16/16 11:55, Paolo Bonzini wrote: > > > On 16/06/2016 08:05, Haozhong Zhang wrote: > > + /* > > + * Only bits masked by msr_ia32_feature_control_valid_bits can be set in > > + * msr_ia32_feature_control. > > + * > > + * msr_ia32_feature_control_valid_bits should be modified by > > + * feature_control_valid_bits_add/del(), and only bits masked by > > + * FEATURE_CONTROL_MAX_VALID_BITS can be modified. > > + */ > > u64 msr_ia32_feature_control; > > + u64 msr_ia32_feature_control_valid_bits; > > I noticed that the fw_cfg patch used an uint32_t. It probably should > use uint64_t; what you did here is correct. >
I'll fix there. Thanks, Haozhong