There are two generics functions phy_ethtool_{get|set}_link_ksettings,
so we can use them instead of defining the same code in the driver.

Signed-off-by: Philippe Reynes <trem...@gmail.com>
---
 drivers/net/ethernet/broadcom/bgmac.c |   20 ++------------------
 1 files changed, 2 insertions(+), 18 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/bgmac.c 
b/drivers/net/ethernet/broadcom/bgmac.c
index 90ed244..e6e74ca 100644
--- a/drivers/net/ethernet/broadcom/bgmac.c
+++ b/drivers/net/ethernet/broadcom/bgmac.c
@@ -1511,22 +1511,6 @@ static void bgmac_get_ethtool_stats(struct net_device 
*dev,
        }
 }
 
-static int bgmac_get_settings(struct net_device *net_dev,
-                             struct ethtool_cmd *cmd)
-{
-       struct bgmac *bgmac = netdev_priv(net_dev);
-
-       return phy_ethtool_gset(net_dev->phydev, cmd);
-}
-
-static int bgmac_set_settings(struct net_device *net_dev,
-                             struct ethtool_cmd *cmd)
-{
-       struct bgmac *bgmac = netdev_priv(net_dev);
-
-       return phy_ethtool_sset(net_dev->phydev, cmd);
-}
-
 static void bgmac_get_drvinfo(struct net_device *net_dev,
                              struct ethtool_drvinfo *info)
 {
@@ -1538,9 +1522,9 @@ static const struct ethtool_ops bgmac_ethtool_ops = {
        .get_strings            = bgmac_get_strings,
        .get_sset_count         = bgmac_get_sset_count,
        .get_ethtool_stats      = bgmac_get_ethtool_stats,
-       .get_settings           = bgmac_get_settings,
-       .set_settings           = bgmac_set_settings,
        .get_drvinfo            = bgmac_get_drvinfo,
+       .get_link_ksettings     = phy_ethtool_get_link_ksettings,
+       .set_link_ksettings     = phy_ethtool_set_link_ksettings,
 };
 
 /**************************************************
-- 
1.7.4.4

Reply via email to