Hi Pali, On Mon, Jun 06, 2016 at 01:23:56PM +0200, Pali Rohár wrote: > This patch series cleanup usage of alps_model_data table. > > Pali Rohár (5): > Input: alps - move ALPS_PROTO_V6 out of alps_model_data table > Input: alps - move ALPS_PROTO_V4 out of alps_model_data table > Input: alps - move ALPS_PROTO_V1 out of alps_model_data table > Input: alps - warn about unsupported ALPS V9 touchpad > Input: alps - cleanup ALPS_PROTO_V2 detection
Frankly, I do not quite like this series. The rule of thumb we had: if we can use e7 data to identify the device it should go into table, if we need to have more elaborate logic - then implement it in __alps_indentify(). I would understand if we got rid of the table completely, but we didn't. I think the patch removing ALPS_PROTO_V4 and subsequent patch removing command_mode_resp from alps_model_info are good, the rest are not so much. Thanks. -- Dmitry
