Hi, On 21/06/2016 at 00:18:22 -0700, Andrey Smirnov wrote : > Hi everyone, > > This set is a v2 of the DS1307 driver patches. Changes since v1: > > - Devicetree bindings are separated into a separate commit > > - Device tree properties now have vendor specific prefixes and > documenatation explicitly stating their type > > - Three more patches, with improvements to rtctest.c, are added to > the patchset >
> Any feedback is appreciated. > > Thank you, > Andrey Smirnov > > Andrey Smirnov (17): > RTC: ds1307: Add DS1341 variant > RTC: ds1307: Disable square wave and timers as default > RTC: ds1307: Add devicetree bindings for DS1341 > RTC: ds1307: Add DS1341 specific power-saving options > RTC: ds1307: Convert ds1307_can_wakeup_device into a predicate > RTC: ds1307: Convert want_irq into a predicate I'll have to triple check that one, it breaks in thousand different ways, every time someone touches that code :) > RTC: ds1307: Move chip configuration into a separate routine > RTC: ds1307: Move chip sanity checking into a separate routine I'm not sure about the cleanup in those two patches yet, It moves a lot of code and the readability improvement is not obvious > RTC: ds1307: Remove register "cache" > RTC: ds1307: Constify struct ds1307 where possible > RTC: ds1307: Convert goto to a loop > RTC: ds1307: Redefine RX8025_REG_* to minimize extra code > RTC: ds1307: Report oscillator problems more intelligently > RTC: ds1307: Move last bits of sanity checking out of chip_configure > RTC: rtctest: Change alarm IRQ support detection > RTC: rtctest: Change no IRQ detection for RTC_IRQP_READ > RTC: rtctest: Change no IRQ detection for RTC_IRQP_SET I already had patches for that issue in a development tree, I'll see if they match what I did. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
