Hi, Jiri Kosina <ji...@kernel.org> writes:
> On Tue, 21 Jun 2016, Heiner Kallweit wrote: > >> Now that support for ThingM blink(1) was merged into the hid-led driver >> the dedicated driver for this device can be removed. >> >> Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> >> --- >> drivers/hid/Kconfig | 10 -- >> drivers/hid/Makefile | 1 - >> drivers/hid/hid-thingm.c | 259 >> ----------------------------------------------- >> 3 files changed, 270 deletions(-) >> delete mode 100644 drivers/hid/hid-thingm.c >> >> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig >> index ab22090..6b08a3b 100644 >> --- a/drivers/hid/Kconfig >> +++ b/drivers/hid/Kconfig >> @@ -828,16 +828,6 @@ config HID_TOPSEED >> Say Y if you have a TopSeed Cyberlink or BTC Emprex or Conceptronic >> CLLRCMCE remote control. >> >> -config HID_THINGM > > Overall the patchset looks good to me. I'd suggest we keep > CONFIG_HID_THINGM as a stub though, that'd just select CONFIG_HID_LED, so > that we don't cause kernel config regressions for users who had > CONFIG_HID_THINGM already turned on. > > Also adding Vivien Didelot to CC, as the author of the original driver. > Vivien, the full set can be found in linux-input archives ( > http://marc.info/?l=linux-input&r=1&b=201606&w=2 ) Thanks a lot for the follow-up Jiri. If you guys decide to remove hid-thingm.c, you need to update the MAINTAINERS entry, checkpatch.pl should have warned about that. I can hardly test the patchset now. Heiner, can you confirm me that with your patchset, we will still see 3 led_classdev in sysfs for the blink(1) mk1 (which has one RGB chip) and 6 for mk2 (which has 2 chips)? Thanks, Vivien
