On Wed, Jun 22, 2016 at 05:52:28PM -0700, Randy Dunlap wrote: > On 06/22/16 17:37, Greg KH wrote: > > On Wed, Jun 22, 2016 at 04:41:07PM -0700, Randy Dunlap wrote: > >> On 06/22/16 03:49, Hans de Bruin wrote: > >>> On 06/20/2016 07:17 PM, Randy Dunlap wrote: > >>>> On 06/20/16 08:43, Greg KH wrote: > >>>>> On Sun, Jun 19, 2016 at 09:12:29AM +0200, Hans de Bruin wrote: > >>>>>> On 06/08/2016 03:43 AM, Greg KH wrote: > >>>>>>> I'm announcing the release of the 4.4.13 kernel. > >>>>>>> > >>>>>> > >>>>>> Hi, > >>>>>> > >>>>>> I tried to compile 4.4.13 using my 4.4.7 config file and ran in to > >>>>>> this: > >>>>>> > >>>>>> LD init/built-in.o > >>>>>> drivers/built-in.o: In function `adf_register_ctl_device_driver': > >>>>>> adf_ctl_drv.c:(.init.text+0x14915): undefined reference to > >>>>>> `adf_init_pf_wq' > >>>>>> adf_ctl_drv.c:(.init.text+0x14927): undefined reference to > >>>>>> `adf_exit_pf_wq' > >>>>>> drivers/built-in.o: In function `adf_unregister_ctl_device_driver': > >>>>>> adf_ctl_drv.c:(.exit.text+0xacf): undefined reference to > >>>>>> `adf_exit_pf_wq' > >>>>>> make[2]: *** [vmlinux] Error 1 > >>>>>> make[1]: *** [sub-make] Error 2 > >>>>>> make: *** [__sub-make] Error 2 > >>>>>> > >>>>>> > >>>>>> I have got some Google hits on this error referencing to higher kernel > >>>>>> versions but not on 4.4: > >>>>>> > >>>>>> LKML: Herbert Xu: Crypto Fixes for 4.6 > >>>>>> > >>>>>> LKML: Greg KH: Linux 4.5.5 > >>>>> > >>>>> I don't understand, what needs to be done in the 4.4-stable tree to > >>>>> resolve this? > >>>> > >>>> Maybe some other DEV_QAT drivers need to add "select PCI_IOV". > >>>> > >>>> See commit 75910d375ecb2079b3418f8b304fd775916025e2 (sorry, I don't > >>>> have the 4.4.x stable git tree [yet]). > >>>> > >>>> Hans, please send your failing .config file. > >>>> > >>> > >>> Randy, > >>> > >>> Attached is the config from my running 4.4.7 kernel. > >> > >> Thanks. > >> > >> I see that GregKH has released 4.4.14-stable for review and it contains > >> a patch for this build error. > > > > I hope it does, verifying it would be great, if you can. > > I made a patch almost exactly like the one that you have in > 4.4-stable and I verified my patch. (although mine is prettier ;)
I think my version (which was the upstream version), was backported wrong, and I fixed it now... So yours was probably better :) thanks, greg k-h
