On Wed, Jun 22, 2016 at 02:48:24PM -0700, Andy Lutomirski wrote: > > Before I do this, can you explain what the difference is between > crypto_cipher and crypto_skcipher? net/bluetooth/smp.c currently uses > crypto_alloc_skcipher, which you added in:
crypto_cipher operates on a single block. crypto_skcipher uses modes of operations and works on multiple blocks. > > commit 71af2f6bb22a4bf42663e10f1d8913d4967ed07f > Author: Herbert Xu <[email protected]> > Date: Sun Jan 24 21:18:30 2016 +0800 > > Bluetooth: Use skcipher and hash > > Am I just supposed to replace "skcipher" with "cipher" everywhere? If you're operating on one block only then you should use cipher, otherwise skcipher would be the appropriate choice. Cheers, -- Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
