On Sun 04-02-07 10:46:33, Robert P. J. Day wrote:
>
> Since quota.h declares a R/W semaphore, it should include rwsem.h
> explicitly.
>
> Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
Acked-by: Jan Kara <[EMAIL PROTECTED]>
> ---
>
> No, this doesn't fix an *existing* problem, but it's necessary for
> an upcoming patch which will remove all includes of <linux/rwsem.h>
> from all the semaphore.h files.
>
> As I read it, since R/W semaphores have their own header file,
> there's no rationale for the regular semaphore header files to have
> that include statement, so any header file that's been happily picking
> up the rwsem header file by accident (via semaphore.h) should be fixed
> this way.
>
> quota.h appears to be the only file that has this issue building on
> x86 with "make allyesconfig".
>
>
> diff --git a/include/linux/quota.h b/include/linux/quota.h
> index b8fbf26..77db80a 100644
> --- a/include/linux/quota.h
> +++ b/include/linux/quota.h
> @@ -132,6 +132,7 @@ struct if_dqinfo {
>
> #ifdef __KERNEL__
> #include <linux/spinlock.h>
> +#include <linux/rwsem.h>
> #include <linux/mutex.h>
>
> #include <linux/dqblk_xfs.h>
>
> --
> ========================================================================
> Robert P. J. Day
> Linux Consulting, Training and Annoying Kernel Pedantry
> Waterloo, Ontario, CANADA
>
> http://www.fsdev.dreamhosters.com/wiki/index.php?title=Main_Page
> ========================================================================
Honza
--
Jan Kara <[EMAIL PROTECTED]>
SuSE CR Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
