On 03/07/2016 at 14:43:56 +0100, Jonathan Cameron wrote : > On 01/07/16 22:30, Alexandre Belloni wrote: > > Add documentation for ADC keys > > > > Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> > Clean looking binding to me - one comment inline. > > Jonathan > > --- > > Cc: Rob Herring <robh...@kernel.org> > > Cc: devicet...@vger.kernel.org > > > > .../devicetree/bindings/input/adc-keys.txt | 45 > > ++++++++++++++++++++++ > > 1 file changed, 45 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/input/adc-keys.txt > > > > diff --git a/Documentation/devicetree/bindings/input/adc-keys.txt > > b/Documentation/devicetree/bindings/input/adc-keys.txt > > new file mode 100644 > > index 000000000000..873476bb4eab > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/input/adc-keys.txt > > @@ -0,0 +1,45 @@ > > +Allwinner sun4i low res adc attached tablet keys > What is allwinner specific in here? Looks pretty general purpose to me!
That's true, I forgot to change that after shamelessly copy pasting... I was planning to use something like ADC attached resistor ladder buttons, unless you have a better way to describe that. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
