On 05/07/16 15:37, Wanpeng Li wrote: > 2016-06-30 3:07 GMT+08:00 Juri Lelli <[email protected]>: > > setup_new_dl_entity() takes two parameters, but it only actually uses > > one of them, under a different name, to setup a new dl_entity, after: > > > > 2f9f3fdc928 "sched/deadline: Remove dl_new from struct sched_dl_entity" > > > > as we currently do > > > > setup_new_dl_entity(&p->dl, &p->dl) > > > > However, before Luca's change we were doing > > > > setup_new_dl_entity(dl_se, pi_se) > > > > in update_dl_entity() for a dl_se->new entity: we were using pi_se's > > parameters (the potential PI donor) for setting up a new entity. > > > > Restore this behaviour (as we want to correctly initialize parameters of > > a boosted task that enters DEADLINE) by removing the useless second > > parameter of setup_new_dl_entity() and retrieving the top waiter > > directly from inside that function. > > > > Cc: Ingo Molnar <[email protected]> > > Cc: Peter Zijlstra <[email protected]> > > Cc: Steven Rostedt <[email protected]> > > Cc: Luca Abeni <[email protected]> > > Signed-off-by: Juri Lelli <[email protected]> > > > > Reviewed-by: Wanpeng Li <[email protected]> >
Thanks! - Juri
