On Tue, 5 Jul 2016 20:45:17 +0200 Borislav Petkov <b...@alien8.de> wrote:
> On Tue, Jul 05, 2016 at 02:26:48PM -0400, Steven Rostedt wrote: > > > + if (rs->missed) > > > + printk(KERN_WARNING "%s: %d output lines suppressed due to > > > ratelimiting\n", > > > + current->comm, rs->missed); > > > > Is the comm important? > > Yes, we wanna dump the task name which called devkmsg_release(). > > > Maybe add the function that called it? > > > > "%pS", _THIS_IP_ > > > > Perhaps add __always_inline, as _THIS_IP_ will point into the function > > that calls this? > > That would inadvertently be devkmsg_release() in this use case. But > we want to dump the task name which opened and spat so much crap into > /dev/kmsg so as to cause the ratelimiting to hit. > Perhaps we should show both, unless you don't think this will ever be used by anything other than devkmsg? -- Steve
