On Wed, Jul 6, 2016 at 9:40 AM, Andrey Ryabinin <[email protected]> wrote: > > > On 07/06/2016 03:52 AM, [email protected] wrote: >> From: Joonsoo Kim <[email protected]> >> >> There are two bugs on qlist_move_cache(). One is that qlist's tail >> isn't set properly. curr->next can be NULL since it is singly linked >> list and NULL value on tail is invalid if there is one item on qlist. >> Another one is that if cache is matched, qlist_put() is called and >> it will set curr->next to NULL. It would cause to stop the loop >> prematurely. >> >> These problems come from complicated implementation so I'd like to >> re-implement it completely. Implementation in this patch is really >> simple. Iterate all qlist_nodes and put them to appropriate list. Neat trick :) >> Unfortunately, I got this bug sometime ago and lose oops message. >> But, the bug looks trivial and no need to attach oops. >> >> v5: rename some variable for better readability >> v4: fix cache size bug s/cache->size/obj_cache->size/ >> v3: fix build warning >> >> Reviewed-by: Dmitry Vyukov <[email protected]> >> Signed-off-by: Joonsoo Kim <[email protected]> > > Fixes: 55834c59098d ("mm: kasan: initial memory quarantine implementation") > Acked-by: Andrey Ryabinin <[email protected]> > Acked-by: Alexander Potapenko <[email protected]>
-- Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Straße, 33 80636 München Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg
