Re: [PATCH 31/31] mm, vmstat: Remove zone and node double accounting by approximating retries

[Dave Hansen]

On 07/01/2016 01:01 PM, Mel Gorman wrote:
> +#ifdef CONFIG_HIGHMEM
> +extern unsigned long highmem_file_pages;
> +
> +static inline void acct_highmem_file_pages(int zid, enum lru_list lru,
> +                                                     int nr_pages)
> +{
> +     if (is_highmem_idx(zid) && is_file_lru(lru))
> +             highmem_file_pages += nr_pages;
> +}
> +#else

Shouldn't highmem_file_pages technically be an atomic_t (or atomic64_t)?
 We could have highmem on two nodes which take two different LRU locks.