On 07/05/2016 10:29 PM, Abhilash Kesavan wrote:
> +static const struct samsung_pll_rate_table pll1450x_24mhz_tbl[] = {
> + /* rate, m, p, s */
> + PLL_35XX_RATE(2496000000, 208, 2, 0),
Please add U postfix to these constants to address compiler warning
as reported by [email protected]:
>> drivers/clk/samsung/clk-exynos7.c:43:2: warning: this decimal constant is
unsigned only in ISO C90
PLL_35XX_RATE(2496000000, 208, 2, 0),
^~~~~~~~~~~~~
> +static void __init exynos7_clk_atlas_init(struct device_node *np)
> +{
> + void __iomem *reg_base;
> + struct samsung_clk_provider *ctx;
> +
> + reg_base = of_iomap(np, 0);
> + if (!reg_base) {
> + panic("%s: failed to map registers\n", __func__);
> + return;
> + }
> +
> + ctx = samsung_clk_init(np, reg_base, ATLAS_NR_CLK);
> + if (!ctx) {
> + panic("%s: unable to allocate ctx\n", __func__);
You can remove this panic() call, there is already one inside
samsung_clk_init().
