On Thu, Jul 14, 2016 at 09:46:14AM +0300, Netanel Belgazal wrote: > This is a driver for the ENA family of networking devices. > > Signed-off-by: Netanel Belgazal <[email protected]> > --- > > Notes: > Changes in v3: > - Fix compilation warning for 32bit systems. [kbuild test rebot] > - Replace netdev->num_tx_queues with adapter->num_queues in ethtool. > [[email protected]] > - Use get_link_ksettings instread of get_settings (deprecated ethtool > API). [[email protected]] > - Remove rna_nway_reset (ethtool). [[email protected]] > - Add missing break in switch condition. [[email protected]] > - Increase driver version to 1.0.2 > > Changes in v2: > - Increment driver version to 1.0.1 > - Reorder the initialization of the workqueus and the timer service > - Initialize last_keep_alive_jiffies in probe > - Remove ena_trc_* functions in favor of pr_* [[email protected]] > - Fix Tx interrupt control register value [[email protected]] > - Edit ena.txt to focus on technical details [[email protected]] > - Rename small_copy_len tunable to rx_copybreak > [[email protected]] > - Change uint32_t to u32 [[email protected]] > - Return error in ena_com_set_hash_ctrl [[email protected]] > - Fix API documentation [[email protected]] > - Remove redundant check in ena_com_mem_addr_set [[email protected]] > - Add local variables for allocation methods to improve readability > [[email protected]] > - Replace dma_alloc_coherent and __GFP_ZERO flag with dma_zalloc_coherent > [[email protected]] > - Fix style when using dma_alloc_coherent [[email protected]] > - Tx xmit - In case of an error drop the packet and return NETDEV_TX_OK > [[email protected]] > - Reduce the number of parameters in ena_get_dev_stats > [[email protected]] > - Return ret and not 0 in ena_com_set_hash_ctrl [[email protected]] > - Do not initialize variables if the function doesn't read them before > the second write [[email protected]] > - Enums - Replace space with tabs to line the assign value > [[email protected]] > - Remove redundant comments [[email protected]] > > TODO: > - Add bytes variable to set_coalesce ethtool callback and use this > callback > instead of dedicated sysfs files.
Dave and Benjamin, Do you want to see the interrupt moderation extensions to ethtool and the sysfs nodes removed before this lands in net-next? Or should Netanel remove the sysfs bits until we can extend the ethtool interfaces to cover the parameters that ena uses? --msw
