On Thu, Jul 14, 2016 at 09:46:14AM +0300, Netanel Belgazal wrote: > This is a driver for the ENA family of networking devices. > > Signed-off-by: Netanel Belgazal <neta...@annapurnalabs.com> > --- > > Notes: > Changes in v3: > - Fix compilation warning for 32bit systems. [kbuild test rebot] > - Replace netdev->num_tx_queues with adapter->num_queues in ethtool. > [b...@decadent.org.uk] > - Use get_link_ksettings instread of get_settings (deprecated ethtool > API). [b...@decadent.org.uk] > - Remove rna_nway_reset (ethtool). [b...@decadent.org.uk] > - Add missing break in switch condition. [b...@decadent.org.uk] > - Increase driver version to 1.0.2 > > Changes in v2: > - Increment driver version to 1.0.1 > - Reorder the initialization of the workqueus and the timer service > - Initialize last_keep_alive_jiffies in probe > - Remove ena_trc_* functions in favor of pr_* [da...@davemloft.net] > - Fix Tx interrupt control register value [rom...@fr.zoreil.com] > - Edit ena.txt to focus on technical details [rom...@fr.zoreil.com] > - Rename small_copy_len tunable to rx_copybreak > [benjamin.poir...@gmail.com] > - Change uint32_t to u32 [rom...@fr.zoreil.com] > - Return error in ena_com_set_hash_ctrl [rami.ro...@intel.com] > - Fix API documentation [rami.ro...@intel.com] > - Remove redundant check in ena_com_mem_addr_set [rom...@fr.zoreil.com] > - Add local variables for allocation methods to improve readability > [rom...@fr.zoreil.com] > - Replace dma_alloc_coherent and __GFP_ZERO flag with dma_zalloc_coherent > [rom...@fr.zoreil.com] > - Fix style when using dma_alloc_coherent [rom...@fr.zoreil.com] > - Tx xmit - In case of an error drop the packet and return NETDEV_TX_OK > [rom...@fr.zoreil.com] > - Reduce the number of parameters in ena_get_dev_stats > [rom...@fr.zoreil.com] > - Return ret and not 0 in ena_com_set_hash_ctrl [rami.ro...@intel.com] > - Do not initialize variables if the function doesn't read them before > the second write [rom...@fr.zoreil.com] > - Enums - Replace space with tabs to line the assign value > [rom...@fr.zoreil.com] > - Remove redundant comments [rom...@fr.zoreil.com] > > TODO: > - Add bytes variable to set_coalesce ethtool callback and use this > callback > instead of dedicated sysfs files.
Dave and Benjamin, Do you want to see the interrupt moderation extensions to ethtool and the sysfs nodes removed before this lands in net-next? Or should Netanel remove the sysfs bits until we can extend the ethtool interfaces to cover the parameters that ena uses? --msw
