Hi Joe,
On Thu, Jul 14, 2016 at 10:47 AM, Joe Perches <j...@perches.com> wrote:
> On Thu, 2016-07-14 at 10:27 -0700, Tai Nguyen wrote:
>> This patch adds a driver for the SoC-wide (AKA uncore) PMU hardware
>> found in APM X-Gene SoCs.
>
> trivia:
>
>> diff --git a/drivers/perf/xgene_pmu.c b/drivers/perf/xgene_pmu.c
> []
>> +struct xgene_pmu_dev_ctx {
>> + char *name;
>> + struct list_head next;
>> + struct xgene_pmu_dev *pmu_dev;
>> + struct hw_pmu_info inf;
>> +};
>
> Probably better to use something like
> char name[20];
> as the kasprintf can fail and this doesn't
> seem to be freed anywhere.
Okay. I'll fix it shortly.
[...]
Thanks,
--
Tai
