Hi Guenter, On Thu, Jul 21, 2016 at 3:09 PM, Guenter Roeck <[email protected]> wrote: > On Thu, Jul 21, 2016 at 01:55:56PM -0700, Hoan Tran wrote: >> This patch adds hardware temperature and power reading support for >> APM X-Gene SoC using the mailbox communication interface. >> >> Signed-off-by: Hoan Tran <[email protected]> >> --- > > [ ... ] > >> + >> + dev_info(&pdev->dev, "APM X-Gene SoC HW monitor driver registered\n"); >> + >> + return rc; >> + > > Nitpick: rc == 0 here, so return 0; is a better choice. > Otherwise looks good.
Yes, I'll fix it then send v4 shortly. > > Reviewed-by: Guenter Roeck <[email protected]> > > Note that I can not apply the patch at this time due to its dependency. Thanks ! I'll let you know when Rafael applies that dependent patch into linux-next. Thanks Hoan > > Guenter
