On 7/25/2016 11:59 AM, James Hogan wrote:
AT_VECTOR_SIZE_ARCH should be defined with the maximum number of NEW_AUX_ENT entries that ARCH_DLINFO can contain, but it wasn't defined for tile at all even though ARCH_DLINFO will contain one NEW_AUX_ENT for the VDSO address.This shouldn't be a problem as AT_VECTOR_SIZE_BASE includes space for AT_BASE_PLATFORM which tile doesn't use, but lets define it now and add the comment above ARCH_DLINFO as found in several other architectures to remind future modifiers of ARCH_DLINFO to keep AT_VECTOR_SIZE_ARCH up to date. Fixes: 4a556f4f56da ("tile: implement gettimeofday() via vDSO") Signed-off-by: James Hogan<james.ho...@imgtec.com> Cc: Chris Metcalf<cmetc...@mellanox.com> --- arch/tile/include/asm/elf.h | 1 + arch/tile/include/uapi/asm/auxvec.h | 2 ++ 2 files changed, 3 insertions(+)
Thanks, taken into the tile tree. I'm a little dubious that AT_VECTOR_SIZE_ARCH should be being defined in the uapi version of auxvec.h, since I don't see why userspace should be interested in it, but that does seem to be the current convention. Ugh, there are even CONFIG_xxx ifdefs in the x86 and sh uapi/asm/auxvec.h ... Maybe the define could be moved to arch/*/include/asm/elf.h? -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com
