> This patch adds the new extcon type to group the each connecotr > into following five category. This type would be used to handle > the connectors as a group unit instead of a connector unit. > - EXTCON_TYPE_USB : USB connector > - EXTCON_TYPE_CHG : Charger connector > - EXTCON_TYPE_JACK : Jack connector
"Jack" seems to be an internal jargon that many people won't recognize. It's, in fact, 3.5-pi, isn't it? Anyway, this is already being used as an enum with drivers, I'd suggest to add a comment in extcon.h stating that "Jack connector" is usually the 3.5-pi earbud connector. Anyway, I like the direction of this patch. Signed-off-by: MyungJoo Ham <myungjoo....@samsung.com> Cheers, MyungJoo > --- a/include/linux/extcon.h > +++ b/include/linux/extcon.h > @@ -29,6 +29,15 @@ > #include <linux/device.h> > > /* > + * Define the type of supported external connectors > + */ > +#define EXTCON_TYPE_USB BIT(0) /* USB connector */ > +#define EXTCON_TYPE_CHG BIT(1) /* Charger connector */ > +#define EXTCON_TYPE_JACK BIT(2) /* Jack connector */ + /* Usually, this is a 3.5-pi earbud conector */ > +#define EXTCON_TYPE_DISP BIT(3) /* Display connector */ > +#define EXTCON_TYPE_MISC BIT(4) /* Miscellaneous connector */ > + > +/* > * Define the unique id of supported external connectors > */ > #define EXTCON_NONE 0 > -- > 1.9.1 >
