On Mon, Jul 25, 2016 at 04:13:28PM +0100, David Binderman wrote: > Hello there, > > linux-4.7/fs/xfs/xfs_icache.c:1298]: (style) Redundant condition: > eofb. '!eofb || (eofb && eofb.eof_scan_owner!=0)' is equivalent to > '!eofb || eofb.eof_scan_owner!=0' > > Source code is > > ASSERT(!eofb || (eofb && eofb->eof_scan_owner != 0)); > > Maybe better code > > ASSERT(!eofb || (eofb->eof_scan_owner != 0));
Yes, that would be better. But it's probably not worth changing existing code just for that.
