On Tue, 2 Aug 2016 20:13:48 +0800 Baole Ni <[email protected]> wrote:
> I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the > corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. NACK! I find 0444 more readable than S_IRUSR | S_IRGRP | S_IROTH. -- Steve > > Signed-off-by: Chuansheng Liu <[email protected]> > Signed-off-by: Baole Ni <[email protected]> > --- > kernel/rcu/rcutorture.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c > index 084a28a..959971a 100644 > --- a/kernel/rcu/rcutorture.c > +++ b/kernel/rcu/rcutorture.c > @@ -100,7 +100,7 @@ torture_param(bool, verbose, true, > "Enable verbose debugging printk()s"); > > static char *torture_type = "rcu"; > -module_param(torture_type, charp, 0444); > +module_param(torture_type, charp, S_IRUSR | S_IRGRP | S_IROTH); > MODULE_PARM_DESC(torture_type, "Type of RCU to torture (rcu, rcu_bh, ...)"); > > static int nrealreaders; > @@ -188,7 +188,7 @@ static const char *rcu_torture_writer_state_getname(void) > #define RCUTORTURE_RUNNABLE_INIT 0 > #endif > static int torture_runnable = RCUTORTURE_RUNNABLE_INIT; > -module_param(torture_runnable, int, 0444); > +module_param(torture_runnable, int, S_IRUSR | S_IRGRP | S_IROTH); > MODULE_PARM_DESC(torture_runnable, "Start rcutorture at boot"); > > #if defined(CONFIG_RCU_BOOST) && !defined(CONFIG_HOTPLUG_CPU)
