I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- kernel/power/suspend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c index 5b70d64..513e9d4 100644 --- a/kernel/power/suspend.c +++ b/kernel/power/suspend.c @@ -239,7 +239,7 @@ static bool platform_suspend_again(suspend_state_t state) #ifdef CONFIG_PM_DEBUG static unsigned int pm_test_delay = 5; -module_param(pm_test_delay, uint, 0644); +module_param(pm_test_delay, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(pm_test_delay, "Number of seconds to wait before resuming from suspend test"); #endif -- 2.9.2
