I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- drivers/tty/sysrq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c index e513940..515f8c6 100644 --- a/drivers/tty/sysrq.c +++ b/drivers/tty/sysrq.c @@ -1014,9 +1014,9 @@ static const struct kernel_param_ops param_ops_sysrq_reset_seq = { * bootargs behaviour is to continue using module_param here. */ module_param_array_named(reset_seq, sysrq_reset_seq, sysrq_reset_seq, - &sysrq_reset_seq_len, 0644); + &sysrq_reset_seq_len, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); -module_param_named(sysrq_downtime_ms, sysrq_reset_downtime_ms, int, 0644); +module_param_named(sysrq_downtime_ms, sysrq_reset_downtime_ms, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); #else -- 2.9.2
