I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- drivers/s390/scsi/zfcp_qdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s390/scsi/zfcp_qdio.c b/drivers/s390/scsi/zfcp_qdio.c index dbf2b547..19d09f8 100644 --- a/drivers/s390/scsi/zfcp_qdio.c +++ b/drivers/s390/scsi/zfcp_qdio.c @@ -15,7 +15,7 @@ #include "zfcp_qdio.h" static bool enable_multibuffer = 1; -module_param_named(datarouter, enable_multibuffer, bool, 0400); +module_param_named(datarouter, enable_multibuffer, bool, S_IRUSR); MODULE_PARM_DESC(datarouter, "Enable hardware data router support (default on)"); static void zfcp_qdio_handler_error(struct zfcp_qdio *qdio, char *id, -- 2.9.2
