> > On Tue, Aug 02, 2016 at 09:12:54AM -0500, Steve Wise wrote: > > Acked-by: Steve Wise <sw...@opengridcomputing.com> > > > > I have to ask, why did you ack all these? There's several things wrong with > this patch series, but even the point of the patch is mistaken. It makes > readable code much less readable. When you chmod a file, do you type > > chmod 0444 file > > or do you write > > chmod S_IRUSR|S_IRGRP|S_IROTH file > > ? > > Which of the above is easier to figure what is being changed? >
I assumed this was some global "fix up". > Not to mention, because the subject is the same for all 1285 patches, and you > deleted the content of the patch in your ack, there's no way to know what > exactly this ack is for (I haven't received the original patch yet because > it's probably being ratelimited by some mail server). > I acked just the single patches that hit cxgb3/cxgb4. But if this is really garbage, then ignore my ACKs... Steve.
