I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- drivers/s390/char/vmur.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/s390/char/vmur.c b/drivers/s390/char/vmur.c index 6c30e93a..9235f64 100644 --- a/drivers/s390/char/vmur.c +++ b/drivers/s390/char/vmur.c @@ -344,7 +344,7 @@ static ssize_t ur_attr_reclen_show(struct device *dev, return rc; } -static DEVICE_ATTR(reclen, 0444, ur_attr_reclen_show, NULL); +static DEVICE_ATTR(reclen, S_IRUSR | S_IRGRP | S_IROTH, ur_attr_reclen_show, NULL); static int ur_create_attributes(struct device *dev) { -- 2.9.2
