I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- drivers/pci/hotplug/pciehp_core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pci/hotplug/pciehp_core.c b/drivers/pci/hotplug/pciehp_core.c index ac531e6..9e6af11 100644 --- a/drivers/pci/hotplug/pciehp_core.c +++ b/drivers/pci/hotplug/pciehp_core.c @@ -51,10 +51,10 @@ MODULE_AUTHOR(DRIVER_AUTHOR); MODULE_DESCRIPTION(DRIVER_DESC); MODULE_LICENSE("GPL"); -module_param(pciehp_debug, bool, 0644); -module_param(pciehp_poll_mode, bool, 0644); -module_param(pciehp_poll_time, int, 0644); -module_param(pciehp_force, bool, 0644); +module_param(pciehp_debug, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); +module_param(pciehp_poll_mode, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); +module_param(pciehp_poll_time, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); +module_param(pciehp_force, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(pciehp_debug, "Debugging mode enabled or not"); MODULE_PARM_DESC(pciehp_poll_mode, "Using polling mechanism for hot-plug events or not"); MODULE_PARM_DESC(pciehp_poll_time, "Polling mechanism frequency, in seconds"); -- 2.9.2
