I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- drivers/misc/phantom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/phantom.c b/drivers/misc/phantom.c index 3075492..f28488c0 100644 --- a/drivers/misc/phantom.c +++ b/drivers/misc/phantom.c @@ -504,7 +504,7 @@ static struct pci_driver phantom_pci_driver = { .resume = phantom_resume }; -static CLASS_ATTR_STRING(version, 0444, PHANTOM_VERSION); +static CLASS_ATTR_STRING(version, S_IRUSR | S_IRGRP | S_IROTH, PHANTOM_VERSION); static int __init phantom_init(void) { -- 2.9.2
