I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- drivers/mmc/host/wbsd.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/wbsd.c b/drivers/mmc/host/wbsd.c index c3fd16d..f3bc95d 100644 --- a/drivers/mmc/host/wbsd.c +++ b/drivers/mmc/host/wbsd.c @@ -1995,11 +1995,11 @@ static void __exit wbsd_drv_exit(void) module_init(wbsd_drv_init); module_exit(wbsd_drv_exit); #ifdef CONFIG_PNP -module_param_named(nopnp, param_nopnp, uint, 0444); +module_param_named(nopnp, param_nopnp, uint, S_IRUSR | S_IRGRP | S_IROTH); #endif -module_param_named(io, param_io, uint, 0444); -module_param_named(irq, param_irq, uint, 0444); -module_param_named(dma, param_dma, int, 0444); +module_param_named(io, param_io, uint, S_IRUSR | S_IRGRP | S_IROTH); +module_param_named(irq, param_irq, uint, S_IRUSR | S_IRGRP | S_IROTH); +module_param_named(dma, param_dma, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_LICENSE("GPL"); MODULE_AUTHOR("Pierre Ossman <[email protected]>"); -- 2.9.2
