I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- drivers/media/dvb-frontends/stv0367.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb-frontends/stv0367.c b/drivers/media/dvb-frontends/stv0367.c index abc379a..cfc4279 100644 --- a/drivers/media/dvb-frontends/stv0367.c +++ b/drivers/media/dvb-frontends/stv0367.c @@ -37,10 +37,10 @@ #define MAX_XFER_SIZE 64 static int stvdebug; -module_param_named(debug, stvdebug, int, 0644); +module_param_named(debug, stvdebug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); static int i2cdebug; -module_param_named(i2c_debug, i2cdebug, int, 0644); +module_param_named(i2c_debug, i2cdebug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); #define dprintk(args...) \ do { \ -- 2.9.2
