On Tue, Aug 02, 2016 at 06:54:46PM +0800, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the > corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu <chuansheng....@intel.com> > Signed-off-by: Baole Ni <baolex...@intel.com>
Looks good, Reviewed-By: Leon Romanovsky <leo...@mellanox.com> > --- > drivers/infiniband/hw/nes/nes_hw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/nes/nes_hw.c > b/drivers/infiniband/hw/nes/nes_hw.c > index a1c6481..f25c37f 100644 > --- a/drivers/infiniband/hw/nes/nes_hw.c > +++ b/drivers/infiniband/hw/nes/nes_hw.c > @@ -41,7 +41,7 @@ > #include "nes.h" > > static int wide_ppm_offset; > -module_param(wide_ppm_offset, int, 0644); > +module_param(wide_ppm_offset, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); > MODULE_PARM_DESC(wide_ppm_offset, "Increase CX4 interface clock ppm offset, > 0=100ppm (default), 1=300ppm"); > > static u32 crit_err_count; > -- > 2.9.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
signature.asc
Description: Digital signature
