Trimming the cc list.. On 08/02/2016 07:11 AM, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the > corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro.
NACK for the same reasons that others have rejected companion patches. 0644 is much easier to read than S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH. > > Signed-off-by: Chuansheng Liu <[email protected]> > Signed-off-by: Baole Ni <[email protected]> > --- > fs/jfs/super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/jfs/super.c b/fs/jfs/super.c > index cec8814..c348410 100644 > --- a/fs/jfs/super.c > +++ b/fs/jfs/super.c > @@ -67,7 +67,7 @@ struct task_struct *jfsSyncThread; > > #ifdef CONFIG_JFS_DEBUG > int jfsloglevel = JFS_LOGLEVEL_WARN; > -module_param(jfsloglevel, int, 0644); > +module_param(jfsloglevel, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); > MODULE_PARM_DESC(jfsloglevel, "Specify JFS loglevel (0, 1 or 2)"); > #endif
